Skip to content

fix complex_layout_android__scroll_smoothness's lost of input event#66611

Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom
CareF:fix_smoothness
Sep 30, 2020
Merged

fix complex_layout_android__scroll_smoothness's lost of input event#66611
fluttergithubbot merged 1 commit intoflutter:masterfrom
CareF:fix_smoothness

Conversation

@CareF
Copy link
Contributor

@CareF CareF commented Sep 25, 2020

Description

This is to revert #64846 's change to the complex_layout_android__scroll_smoothness test to fix #66608

@CareF CareF requested review from dkwingsmt and liyuqian September 25, 2020 01:03
@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Sep 25, 2020
@flutter-dashboard
Copy link

flutter-dashboard bot commented Sep 25, 2020

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@CareF CareF changed the title fix smoothness fix complex_layout_android__scroll_smoothness's lost of input event Sep 25, 2020
dkwingsmt
dkwingsmt approved these changes Sep 25, 2020
View reviewed changes
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Sep 25, 2020

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Mac build_aar_module_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac gradle_fast_start_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac gradle_plugin_bundle_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac gradle_plugin_fat_apk_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac gradle_plugin_light_apk_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac gradle_r8_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac module_custom_host_app_name_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac module_host_with_custom_build_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac module_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac plugin_lint_mac has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac plugin_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac tool_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

liyuqian
liyuqian approved these changes Sep 25, 2020
View reviewed changes
Copy link
Contributor

@liyuqian liyuqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Sep 26, 2020

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Mac plugin_dependencies_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

@CareF CareF mentioned this pull request Sep 26, 2020
Merged
9 tasks
@fluttergithubbot fluttergithubbot merged commit 07e56d4 into flutter:master Sep 30, 2020
@CareF CareF deleted the fix_smoothness branch September 30, 2020 00:27
@kf6gpe kf6gpe mentioned this pull request Oct 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkwingsmt dkwingsmt dkwingsmt approved these changes

+1 more reviewer

@liyuqian liyuqian liyuqian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

complex_layout_android__scroll_smoothness generates unexpected numbers

5 participants

@CareF @fluttergithubbot @dkwingsmt @liyuqian @googlebot