Merged
Conversation
Contributor
Author
danrubel
approved these changes
Nov 3, 2016
| } else { | ||
| // upper-case 'R'. | ||
| await _restartFromSources(); | ||
| await restart(fullRestart: true); |
Contributor
There was a problem hiding this comment.
collapse if statement into this ?
await restart(fullRestart: code == 'R');
Contributor
|
This needs a merge but LGTM |
Contributor
Author
|
Updated and merged. |
johnmccutchan
approved these changes
Nov 3, 2016
Contributor
johnmccutchan
left a comment
johnmccutchan
left a comment
There was a problem hiding this comment.
LGTM with a minor comment
| if (result.isOk) | ||
| printStatus("${result.message}."); | ||
| return result; | ||
| } catch (error) { |
Contributor
There was a problem hiding this comment.
this could be a finally and rethrow
Contributor
Author
There was a problem hiding this comment.
Makes sense. I updated this to use rethrow; I'm sticking with catch instead of finally since I want a little more control of when stop() is called.
GaryQian
added a commit
that referenced
this pull request
Oct 30, 2018
…#23596) 162b2e9..7be0217 7be0217 Roll back _countryCode assert - breaking change (#6693) 91a019c Fix popSystemNavigator (#6691) 2b2fbf0 Add Locale.fromSubtags and support for scriptCode. (#6518) 58c8e30 Roll src/third_party/skia ab18c8e6cc20..d48b7a881b24 (5 commits) (#6690) 3b17cfb Flutter tester default locales (#6689) 96bbd2b Roll buildroot to 11a934e (#6687) 0e9defb Roll src/third_party/skia 68825776f4b4..ab18c8e6cc20 (11 commits) (#6688) cc686d7 Don't populate the external view embedder in PaintContext. (#6686) ab782fa Roll src/third_party/skia 1de48d8040aa..68825776f4b4 (1 commits) (#6685) c4aa8d3 Roll src/third_party/skia 797197a772b8..1de48d8040aa (2 commits) (#6684) 7352251 Roll src/third_party/skia 79c96811863f..797197a772b8 (1 commits) (#6683) 3dac47e Roll src/third_party/skia 38e4fd0c5654..79c96811863f (1 commits) (#6682) 2f06a53 Roll src/third_party/skia b53f1f46982d..38e4fd0c5654 (1 commits) (#6681) a1d7cad Fix inconsistent include syntax (#6680) 236661c Roll src/third_party/skia 3b79aa3a5ad0..b53f1f46982d (13 commits) (#6679) c4f5061 Roll buildroot to pick up Mac toolchain updates. (#6678) ba8f6aa Handle Windows headers defining ERROR to 0 in log levels. (#6677) 505d2a9 Roll buildroot to pick up updates to custom toolchains. (#6674) 6c2a0b3 Undefine ERROR in platform_view_layer.cc (#6675) 55e1299 Update FlutterPlugin.h docs, suppress warning for older API (#6672) f797004 Attach and position embedded UIVIews (#6614) df85722 Plumb the iOS PlatformViewsController into flow. (#6603) 2bfb893 iOS Embedding Refactor (#6447)
Xavjer
pushed a commit
to Xavjer/flutter
that referenced
this pull request
Nov 1, 2018
…flutter#23596) 162b2e9..7be0217 7be0217 Roll back _countryCode assert - breaking change (flutter#6693) 91a019c Fix popSystemNavigator (flutter#6691) 2b2fbf0 Add Locale.fromSubtags and support for scriptCode. (flutter#6518) 58c8e30 Roll src/third_party/skia ab18c8e6cc20..d48b7a881b24 (5 commits) (flutter#6690) 3b17cfb Flutter tester default locales (flutter#6689) 96bbd2b Roll buildroot to 11a934e (flutter#6687) 0e9defb Roll src/third_party/skia 68825776f4b4..ab18c8e6cc20 (11 commits) (flutter#6688) cc686d7 Don't populate the external view embedder in PaintContext. (flutter#6686) ab782fa Roll src/third_party/skia 1de48d8040aa..68825776f4b4 (1 commits) (flutter#6685) c4aa8d3 Roll src/third_party/skia 797197a772b8..1de48d8040aa (2 commits) (flutter#6684) 7352251 Roll src/third_party/skia 79c96811863f..797197a772b8 (1 commits) (flutter#6683) 3dac47e Roll src/third_party/skia 38e4fd0c5654..79c96811863f (1 commits) (flutter#6682) 2f06a53 Roll src/third_party/skia b53f1f46982d..38e4fd0c5654 (1 commits) (flutter#6681) a1d7cad Fix inconsistent include syntax (flutter#6680) 236661c Roll src/third_party/skia 3b79aa3a5ad0..b53f1f46982d (13 commits) (flutter#6679) c4f5061 Roll buildroot to pick up Mac toolchain updates. (flutter#6678) ba8f6aa Handle Windows headers defining ERROR to 0 in log levels. (flutter#6677) 505d2a9 Roll buildroot to pick up updates to custom toolchains. (flutter#6674) 6c2a0b3 Undefine ERROR in platform_view_layer.cc (flutter#6675) 55e1299 Update FlutterPlugin.h docs, suppress warning for older API (flutter#6672) f797004 Attach and position embedded UIVIews (flutter#6614) df85722 Plumb the iOS PlatformViewsController into flow. (flutter#6603) 2bfb893 iOS Embedding Refactor (flutter#6447)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sample output: