Add benchmark/test for drawing images across frames#67176
Merged
dnfield merged 1 commit intoflutter:masterfrom Oct 2, 2020
Merged
Add benchmark/test for drawing images across frames#67176dnfield merged 1 commit intoflutter:masterfrom
dnfield merged 1 commit intoflutter:masterfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flutter-dashboard
bot
added
the
c: contributor-productivity
dnfield
added a commit
to dnfield/flutter
that referenced
this pull request
Oct 2, 2020
Changes since last time: - Test for CanvasKit image rendering (flutter#67176) - Fix CanvasKit dispose impl (flutter/engine#21555) - Update internal google3 customer with a problematic ImageStream Listener impl (cl/335091311) This reverts commit 473358d.
liyuqian
added
the
c: performance
Contributor
|
Does this need to be run in the devicelab and report the metrics? |
dnfield
added a commit
that referenced
this pull request
Oct 5, 2020
* Reland dispose images when done (#67100) Changes since last time: - Test for CanvasKit image rendering (#67176) - Fix CanvasKit dispose impl (flutter/engine#21555) - Update internal google3 customer with a problematic ImageStream Listener impl (cl/335091311, cl/335459002) This reverts commit 473358d.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would have caught the CanvasKit regression introduced in #66688