Skip to content

Add the missing parantheses#67446

Merged
liyuqian merged 1 commit intoflutter:masterfrom
liyuqian:bug_fix
Oct 8, 2020
Merged

Add the missing parantheses#67446
liyuqian merged 1 commit intoflutter:masterfrom
liyuqian:bug_fix

Conversation

@liyuqian
Copy link
Contributor

@liyuqian liyuqian commented Oct 6, 2020

Fixes #67343

@liyuqian liyuqian requested review from flar and goderbauer October 6, 2020 20:17
@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Oct 6, 2020
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Any chance you can add a test for this to avoid breaking this again in the future?

@liyuqian
Copy link
Contributor Author

liyuqian commented Oct 6, 2020

Sure, I'd like to add a test. But I didn't immediately see an easy way to add a test as this may involve platform views. I posted this first without a test just in case that fixing this typo is urgent. Please let me know if you think we can wait for a test maybe by next week as I'm the engine sheriff this week, or we shall land this first, and later add a test. Meanwhile, I filed #67455 to double ensure that we don't forget that test.

@liyuqian liyuqian merged commit 587dd00 into flutter:master Oct 8, 2020
xu-baolin added a commit to xu-baolin/flutter that referenced this pull request Oct 12, 2020
@xu-baolin
Copy link
Member

Test case added by #67913

@liyuqian liyuqian deleted the bug_fix branch November 3, 2020 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Potential logical operator bug introduced in recent PR

4 participants