Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
goderbauer
left a comment
There was a problem hiding this comment.
LGTM
Any chance you can add a test for this to avoid breaking this again in the future?
|
Sure, I'd like to add a test. But I didn't immediately see an easy way to add a test as this may involve platform views. I posted this first without a test just in case that fixing this typo is urgent. Please let me know if you think we can wait for a test maybe by next week as I'm the engine sheriff this week, or we shall land this first, and later add a test. Meanwhile, I filed #67455 to double ensure that we don't forget that test. |
|
Test case added by #67913 |
Fixes #67343