Revert "Flutter Driver - Create widget finders from serialized finders extensions"#67687
Merged
jonahwilliams merged 1 commit intomasterfrom Oct 8, 2020
Merged
Revert "Flutter Driver - Create widget finders from serialized finders extensions"#67687jonahwilliams merged 1 commit intomasterfrom
jonahwilliams merged 1 commit intomasterfrom
Conversation
flutter-dashboard
bot
added
a: tests
Contributor
|
LGTM. @marcin-jelenski FYI - we'll try to get this relanded shortly, but it created a bunch of merge conflicts in another patch we're trying to get through sooner than later. |
Contributor
|
(since this patch is smaller, it's easier to fix up the conflicts when we reland this than vice versa) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #67456
This is complicating the reland of the null safety migration #67570 (review)
Revert so it can be relanded in the context of null safety
TBR @dnfield