Add test case for AndroidView clipBehavior by xu-baolin · Pull Request #67913 · flutter/flutter

xu-baolin · 2020-10-12T11:15:39Z

Description

@liyuqian

Add a test case for AndroidView clipBehavior

Related Issues

Fixes #67455
#67343

Tests

See files.

liyuqian

Thanks for writing this test! Here are a few minor comments.

liyuqian · 2020-10-12T17:43:23Z

packages/flutter/test/widgets/platform_view_test.dart

      }
    });
+
+    testWidgets('clipBehavior test', (WidgetTester tester) async {


nit: make the test name more descriptive such as 'clip is handled correctly during resizing'

liyuqian · 2020-10-12T18:00:20Z

packages/flutter/test/widgets/platform_view_test.dart

+        );
+      }
+
+      await tester.pumpWidget(buildView(200.0, 200.0, Clip.none));


This test seems to rely on RenderAndroidView to be retained in its last size while the parent widget resizes. I can't find any description about this behavior in https://master-api.flutter.dev/flutter/widgets/AndroidView-class.html. CC @cyanglaz @amirh to double check if this is expected and whether we can rely on this.

There is an existing test case to test this behavior:

flutter/packages/flutter/test/widgets/platform_view_test.dart

Lines 106 to 154 in 4cfd7d3

testWidgets('Resize Android view', (WidgetTester tester) async {

final int currentViewId = platformViewsRegistry.getNextPlatformViewId();

final FakeAndroidPlatformViewsController viewsController = FakeAndroidPlatformViewsController();

viewsController.registerViewType('webview');

await tester.pumpWidget(

const Center(

child: SizedBox(

width: 200.0,

height: 100.0,

child: AndroidView(viewType: 'webview', layoutDirection: TextDirection.ltr),

),

),

);

viewsController.resizeCompleter = Completer<void>();

await tester.pumpWidget(

const Center(

child: SizedBox(

width: 100.0,

height: 50.0,

child: AndroidView(viewType: 'webview', layoutDirection: TextDirection.ltr),

),

),

);

final Layer textureParentLayer = tester.layers[tester.layers.length - 2];

expect(textureParentLayer, isA<ClipRectLayer>());

final ClipRectLayer clipRect = textureParentLayer as ClipRectLayer;

expect(clipRect.clipRect, const Rect.fromLTWH(0.0, 0.0, 100.0, 50.0));

expect(

viewsController.views,

unorderedEquals(<FakeAndroidPlatformView>[

FakeAndroidPlatformView(currentViewId + 1, 'webview', const Size(200.0, 100.0),

AndroidViewController.kAndroidLayoutDirectionLtr, null),

]),

);

viewsController.resizeCompleter.complete();

await tester.pump();

expect(

viewsController.views,

unorderedEquals(<FakeAndroidPlatformView>[

FakeAndroidPlatformView(currentViewId + 1, 'webview', const Size(100.0, 50.0),

AndroidViewController.kAndroidLayoutDirectionLtr, null),

]),

);

});

liyuqian · 2020-10-12T18:07:35Z

packages/flutter/test/widgets/platform_view_test.dart

+      // No clip happen when the clip behavior is `Clip.none` .
+      expect(tester.layers.whereType<ClipRectLayer>(), hasLength(0));
+
+      // No clip happen when the clip behavior only change.


// No clip happen when the clip behavior only change. -> // No clip when only the clip behavior changes while the size remains the same.

liyuqian

LGTM

Add test case for flutter#67446

0300740

flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Oct 12, 2020

google-cla bot added the cla: yes label Oct 12, 2020

Remove unused var

4cfd7d3

This was referenced Oct 12, 2020

Add the missing parantheses #67446

Merged

Create a test for RenderAndroidView's clip logic #67455

Closed

liyuqian reviewed Oct 12, 2020

View reviewed changes

For code review suggestions.

9ec6c9e

liyuqian approved these changes Oct 13, 2020

View reviewed changes

goderbauer added the waiting for tree to go green label Oct 14, 2020

fluttergithubbot merged commit f2d5f1f into flutter:master Oct 14, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add test case for AndroidView clipBehavior#67913

Add test case for AndroidView clipBehavior#67913
fluttergithubbot merged 3 commits intoflutter:masterfrom
xu-baolin:cliptest101201

xu-baolin commented Oct 12, 2020 •

edited

Loading

Uh oh!

liyuqian left a comment

Uh oh!

liyuqian Oct 12, 2020

Uh oh!

liyuqian Oct 12, 2020

Uh oh!

xu-baolin Oct 13, 2020

Uh oh!

liyuqian Oct 12, 2020

Uh oh!

liyuqian left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	testWidgets('Resize Android view', (WidgetTester tester) async {
	final int currentViewId = platformViewsRegistry.getNextPlatformViewId();
	final FakeAndroidPlatformViewsController viewsController = FakeAndroidPlatformViewsController();
	viewsController.registerViewType('webview');
	await tester.pumpWidget(
	const Center(
	child: SizedBox(
	width: 200.0,
	height: 100.0,
	child: AndroidView(viewType: 'webview', layoutDirection: TextDirection.ltr),
	),
	),
	);

	viewsController.resizeCompleter = Completer<void>();

	await tester.pumpWidget(
	const Center(
	child: SizedBox(
	width: 100.0,
	height: 50.0,
	child: AndroidView(viewType: 'webview', layoutDirection: TextDirection.ltr),
	),
	),
	);

	final Layer textureParentLayer = tester.layers[tester.layers.length - 2];
	expect(textureParentLayer, isA<ClipRectLayer>());
	final ClipRectLayer clipRect = textureParentLayer as ClipRectLayer;
	expect(clipRect.clipRect, const Rect.fromLTWH(0.0, 0.0, 100.0, 50.0));
	expect(
	viewsController.views,
	unorderedEquals(<FakeAndroidPlatformView>[
	FakeAndroidPlatformView(currentViewId + 1, 'webview', const Size(200.0, 100.0),
	AndroidViewController.kAndroidLayoutDirectionLtr, null),
	]),
	);

	viewsController.resizeCompleter.complete();
	await tester.pump();

	expect(
	viewsController.views,
	unorderedEquals(<FakeAndroidPlatformView>[
	FakeAndroidPlatformView(currentViewId + 1, 'webview', const Size(100.0, 50.0),
	AndroidViewController.kAndroidLayoutDirectionLtr, null),
	]),
	);
	});

Conversation

xu-baolin commented Oct 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Tests

Uh oh!

liyuqian left a comment

Choose a reason for hiding this comment

Uh oh!

liyuqian Oct 12, 2020

Choose a reason for hiding this comment

Uh oh!

liyuqian Oct 12, 2020

Choose a reason for hiding this comment

Uh oh!

xu-baolin Oct 13, 2020

Choose a reason for hiding this comment

Uh oh!

liyuqian Oct 12, 2020

Choose a reason for hiding this comment

Uh oh!

liyuqian left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

xu-baolin commented Oct 12, 2020 •

edited

Loading