Set slider semantics flag for sliders#68019
Merged
fluttergithubbot merged 3 commits intoflutter:masterfrom Oct 19, 2020
Merged
Conversation
flutter-dashboard
bot
added
a: tests
guidezpl
approved these changes
Oct 14, 2020
Member
guidezpl
left a comment
guidezpl
left a comment
There was a problem hiding this comment.
Thanks for contributing!
_ ___ _____ __ __
| | / __|_ _| \/ |
| |_| (_ | | | | |\/| |
|____\___| |_| |_| |_|
Contributor
Author
Thanks!! Just quick question 😅 is it possible to add the label hacktoberfest-accepted so it count for the challenge? 😅 |
Member
|
I don't think we're a participating repo, but let me ask. cc @kf6gpe |
Contributor
|
Yeah, unfortunately we're not participating!! It's a good idea, though --- and thanks for your contribution! |
Contributor
Author
|
Alright, maybe next year! Thanks for letting us contribute to this repo! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add the semantics flag for the sliders (
Slider,RangeSliderandCupertinoSlider).Related Issues
Replace this paragraph with a list of issues related to this PR from our issue database. Indicate, which of these issues are resolved or fixed by this PR. There should be at least one issue listed here.
Linked to:
Tests
I didn't add any tests but changed the following tests:
Slider SemanticsandSlider Semantics can be updatedRange Slider SemanticsSlider Semantics(l.1314 and l.1474) andSlider semantics with custom formatterChecklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///). I don't know what to add or updateflutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.
Other information
After reviewing this PR if this is possible to add the label: hacktoberfest-accepted that would be wonderful. This is for the hacktoberfest challenge