[MergeSemantics] added code snippet#68123
Merged
fluttergithubbot merged 3 commits intoflutter:masterfrom Oct 19, 2020
AyushBherwani1998:mergesemantics-patch
Merged
[MergeSemantics] added code snippet#68123fluttergithubbot merged 3 commits intoflutter:masterfrom AyushBherwani1998:mergesemantics-patch
fluttergithubbot merged 3 commits intoflutter:masterfrom
AyushBherwani1998:mergesemantics-patch
Conversation
flutter-dashboard
bot
added
the
framework
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
AyushBherwani1998
changed the title
chunhtai
approved these changes
Oct 14, 2020
Contributor
chunhtai
left a comment
chunhtai
left a comment
There was a problem hiding this comment.
LGTM, modulo styling nitpick
| /// children: [ | ||
| /// Checkbox( | ||
| /// value: true, | ||
| /// onChanged: (value) {}, |
Contributor
There was a problem hiding this comment.
type the value and use arrow method for one liner
(bool value) => null,
Member
Author
There was a problem hiding this comment.
Ugh, sorry for the nits. Should have done a double check. I have fixed them. Thanks for quick review :)
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
…esemantics-patch
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added MergeSemantics code snippet
Related Issues
Fixes #22782
Tests
I added the following tests:
Only doc changes
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.