Skip to content

enable unnecessary_string_escapes and use_raw_strings#68302

Merged
a14n merged 1 commit intoflutter:masterfrom
a14n:string-lints
Oct 21, 2020
Merged

enable unnecessary_string_escapes and use_raw_strings#68302
a14n merged 1 commit intoflutter:masterfrom
a14n:string-lints

Conversation

@a14n
Copy link
Contributor

@a14n a14n commented Oct 16, 2020

Description

Enable lints:

Related Issues

None

Tests

None

@flutter-dashboard flutter-dashboard bot added a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Oct 16, 2020
@google-cla google-cla bot added the cla: yes label Oct 16, 2020
@a14n a14n force-pushed the string-lints branch 2 times, most recently from 4b655ee to 0eab7fd Compare October 16, 2020 13:54
@a14n a14n requested a review from goderbauer October 16, 2020 15:11
goderbauer
goderbauer reviewed Oct 16, 2020
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but @shihaohong can you confirm that the changes to the localization code look ok?

shihaohong
shihaohong approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@shihaohong shihaohong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L10n code LGTM

@a14n a14n merged commit ae06c19 into flutter:master Oct 21, 2020
@a14n a14n deleted the string-lints branch October 21, 2020 14:34
zanderso added a commit that referenced this pull request Oct 21, 2020
@zanderso
Revert "enable unnecessary_string_escapes and use_raw_strings (#68302)"
eb651d2 
This reverts commit ae06c19.
@zanderso zanderso mentioned this pull request Oct 21, 2020
Merged
zanderso added a commit that referenced this pull request Oct 21, 2020
@zanderso
Revert "enable unnecessary_string_escapes and use_raw_strings (#68302)…
cbcd132 
…" (#68714)

This reverts commit ae06c19.
a14n added a commit to a14n/flutter that referenced this pull request Oct 26, 2020
@a14n
enable unnecessary_string_escapes and use_raw_strings (flutter#68302)
571df6f
@a14n a14n mentioned this pull request Oct 26, 2020
Merged
fluttergithubbot pushed a commit that referenced this pull request Oct 26, 2020
@a14n
enable unnecessary_string_escapes and use_raw_strings (#68302) (#69025)
17cdf55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer left review comments

+1 more reviewer

@shihaohong shihaohong shihaohong approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@a14n @goderbauer @shihaohong