[flutter_tools] retry the driver launch of the application up to 3 times.#68334
Merged
jonahwilliams merged 5 commits intoflutter:masterfrom Oct 16, 2020
Merged
[flutter_tools] retry the driver launch of the application up to 3 times.#68334jonahwilliams merged 5 commits intoflutter:masterfrom
jonahwilliams merged 5 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
the
tool
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Contributor
Author
|
OTOH - if these retries always fail, it might mean that there is a problem with the APK/bundle as built, which could be something else in the stack entirely |
added 2 commits
October 16, 2020 13:58
jmagman
approved these changes
Oct 16, 2020
Member
jmagman
left a comment
jmagman
left a comment
There was a problem hiding this comment.
LGTM as a temporary experiment 🧬
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We'd like to see how many of these flakes are transient and how many involve the device/machine getting temporarily wedged. Add a retry with no delay to see if it is possible to add sufficient error handling to startApp/installApp to handle this.