Skip to content

Build iOS apps using Swift Packages#68361

Merged
fluttergithubbot merged 3 commits intoflutter:masterfrom
jmagman:spm-legacy
Oct 19, 2020
Merged

Build iOS apps using Swift Packages#68361
fluttergithubbot merged 3 commits intoflutter:masterfrom
jmagman:spm-legacy

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Oct 16, 2020

Description

Another attempt at #59009. The only difference is that I removed the devicelab test that always passed on my machine but never in the devicelab... which is kind of lame but we probably don't want to add a new Swift package dependency there anyway.

Swift packages cannot be added to a newly created Flutter iOS app due to the Xcode project settings (not workspace) being set to the "legacy" build location. Update to the "default" Xcode build location.
73312223-10950180-41dd-11ea-9a66-98d3a140f0fd

Screen Shot 2020-06-02 at 1 56 59 PM

Update templates, add tool migrator, let tool upgrade all examples and integration tests.

Related Issues

Fixes #57083
Related to #49654

Redux of #59009

Tests

  • Migrator tests

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@jmagman jmagman self-assigned this Oct 16, 2020
@flutter-dashboard flutter-dashboard bot added d: examples Sample code and demos c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Oct 16, 2020
@google-cla google-cla bot added the cla: yes label Oct 16, 2020
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

3 participants