[devicelab] update hostonly tests to use flutter directly or precache deps#68487
Merged
jonahwilliams merged 5 commits intoflutter:masterfrom Oct 19, 2020
Merged
[devicelab] update hostonly tests to use flutter directly or precache deps#68487jonahwilliams merged 5 commits intoflutter:masterfrom
jonahwilliams merged 5 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
the
c: contributor-productivity
| }); | ||
|
|
||
| await runProjectTest((FlutterProject project) async { | ||
| if (Platform.isWindows) { |
Contributor
There was a problem hiding this comment.
We don't need this anymore?
Contributor
Author
There was a problem hiding this comment.
works on my computer (and on CI) 🤷🏻♂️
christopherfujino
approved these changes
Oct 19, 2020
Contributor
christopherfujino
left a comment
christopherfujino
left a comment
There was a problem hiding this comment.
LGTM. This is a great improvement!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #67370
By running most of these executions through flutter, we get the benefit of the flutter error handling and precaching. IN the test where this is not feasible, call pre-cache directly.