Conversation
- test: 1.16.0-nullsafety.6 - test_api: 0.2.19-nullsafety.3 - test_core: 0.3.12-nullsafety.6
flutter-dashboard
bot
added
c: contributor-productivity
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| dependencies: | ||
| args: 1.6.0 | ||
| file: 6.0.0-nullsafety.2 | ||
| http: 0.12.2 |
There was a problem hiding this comment.
Had this been missing before?
There was a problem hiding this comment.
Yeah, I had to move this manually from dev_dependencies below to here before running flutter update-packages --force-upgrade. I believe the removal of package:http from package:test 1.16.0-nullsafety.6 causes the command to remove it from dev_dependencies below, and it actually should be a dependency.
|
Unfortunately it looks like someone else updated packages before you? You'll need to rebase first. |
|
No worries, the conflicting PR that was merged already updates the dependencies needed here. |
3 participants
Description
Update to the following:
Motivation: We want to use a the new APIs provided in the new version of
package:test_coreinpackage:integration_test, but there is a dependency conflict. This is becausepackage:integration_testdepends onpackage:flutter_testandpackage:flutter_driver, both of which also transitively depends on a conflicting pinned version of `package:test_core.I'm not too familiar with the process for doing this, let me know if this isn't correct. These are the steps I took:
packages/flutter_tools/lib/src/commands/update_packages.dartpackages/flutter_tools/pubspec.yamlhttpindev/devicelab/pubspec.yamlfromdev_dependenciestodependencies. This is needed because it's actually used as a normal dependency. The newpackage:test1.16.0-nullsafety.6removes the dependency onpackage:http. If I run theupdate-packagescommand without doing so,httpwill be removed fromdev_dependencies, breaking the build.flutter update-packages --force-upgrade.