Send command line arguments through to the Flutter Engine on Windows#68931
Merged
fluttergithubbot merged 3 commits intoflutter:masterfrom Oct 30, 2020
Merged
Send command line arguments through to the Flutter Engine on Windows#68931fluttergithubbot merged 3 commits intoflutter:masterfrom
fluttergithubbot merged 3 commits intoflutter:masterfrom
Conversation
stuartmorgan-g
requested changes
Oct 26, 2020
packages/flutter_tools/templates/app/windows.tmpl/runner/main.cpp.tmpl
Outdated
Show resolved
Hide resolved
packages/flutter_tools/templates/app/windows.tmpl/runner/main.cpp.tmpl
Outdated
Show resolved
Hide resolved
packages/flutter_tools/templates/app/windows.tmpl/runner/main.cpp.tmpl
Outdated
Show resolved
Hide resolved
stuartmorgan-g
approved these changes
Oct 28, 2020
packages/flutter_tools/templates/app/windows.tmpl/runner/utils.h
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This takes the command line arguments on Windows, converts them to UTF-8 then passes them into the engine via the API added in flutter/engine#22094
Related Issues
#32986
Tests
None
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.