reland driver vm_service migration#69126
Merged
dnfield merged 2 commits intoflutter:masterfrom Oct 27, 2020
Merged
Conversation
…" (flutter#69077)" (flutter#69089)" This reverts commit e581475.
flutter-dashboard
bot
added
a: tests
Contributor
Author
|
Failure is fixed on master. Going to land this as is. |
Contributor
Author
|
This one looks like it's going to stick! |
Contributor
|
Following this PR integration tests in flutter/plugins are failing with: See: https://cirrus-ci.com/task/4631268350492672?command=build#L255 I'm not sure if it means that the code in flutter/plugins was bad to start with, but we should probably consider this as a breaking change... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diff from last time is in 6c086e4
@jonahwilliams
See (#68654) (#69074) (#69077) (#69089) for history