Skip to content

Make the launch background drawable compatible with older Android API levels#69255

Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom
jason-simmons:launch_background_api21
Nov 3, 2020
Merged

Make the launch background drawable compatible with older Android API levels#69255
fluttergithubbot merged 1 commit intoflutter:masterfrom
jason-simmons:launch_background_api21

Conversation

@jason-simmons
Copy link
Member

The #65182 change introduced a
drawable with a reference to a theme attribute. Loading this requires
a Resources.getDrawable API introduced in API level 21.

@jason-simmons jason-simmons requested a review from xster October 28, 2020 23:40
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 28, 2020
@google-cla google-cla bot added the cla: yes label Oct 28, 2020
@jason-simmons jason-simmons force-pushed the launch_background_api21 branch from 5187072 to 1d9081a Compare October 30, 2020 18:23
@jason-simmons jason-simmons requested a review from blasten November 2, 2020 21:17
… levels

The flutter#65182 change introduced a
drawable with a reference to a theme attribute.  Loading this requires
a Resources.getDrawable API introduced in API level 21.
@jason-simmons jason-simmons force-pushed the launch_background_api21 branch from 1d9081a to 2b0c5dd Compare November 2, 2020 21:18
Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xster
Copy link
Member

xster commented Nov 3, 2020

Thanks Jason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants