[gen_l10n] Fix unintended use of raw string in generateString#69382
Merged
shihaohong merged 4 commits intoflutter:masterfrom Oct 31, 2020
shihaohong:failing-genl10n-test
Merged
[gen_l10n] Fix unintended use of raw string in generateString#69382shihaohong merged 4 commits intoflutter:masterfrom shihaohong:failing-genl10n-test
shihaohong merged 4 commits intoflutter:masterfrom
shihaohong:failing-genl10n-test
Conversation
jonahwilliams
approved these changes
Oct 30, 2020
Contributor
jonahwilliams
left a comment
There was a problem hiding this comment.
LGTM (but not to CI...)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #69345, which fails because of a change that uses raw strings as part of the code generation introduced by #69025.
This PR simply reverts the generateString logic for the gen_l10n tool, but keeps the Material/Cupertino generated localizations one intact. Since the introduced logic prefers raw strings (which the flutter/flutter linters now enforce), this is necessary for the Material and Cupertino library code generators. However, this approach fails with
gen_l10n.For example:
^ This is okay in our cupertino and material delegate generation code because it parses raw strings with interpolated variables differently (see this example).
However, in gen_l10n, this becomes a little weird, both in the code comments:
and also in the delegate code:
instead of
Related Issues
Fixes #69345
Tests
I added the following tests:
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.