Remove need for loader and boot the application directly even when hot reloading#6948
Merged
johnmccutchan merged 1 commit intoflutter:masterfrom Nov 22, 2016
johnmccutchan:kill_loader
Merged
Remove need for loader and boot the application directly even when hot reloading#6948johnmccutchan merged 1 commit intoflutter:masterfrom johnmccutchan:kill_loader
johnmccutchan merged 1 commit intoflutter:masterfrom
johnmccutchan:kill_loader
Conversation
johnmccutchan
changed the title
Contributor
Author
devoncarew
reviewed
Nov 21, 2016
tvolkert
reviewed
Nov 21, 2016
Contributor
tvolkert
left a comment
tvolkert
left a comment
There was a problem hiding this comment.
The Travis failures look unrelated - maybe kick the bot to try again?
Contributor
There was a problem hiding this comment.
Debugging change mistakenly pushed?
Contributor
Author
There was a problem hiding this comment.
Yes and fixed.
Contributor
|
lgtm, but it looks like travis is unhappy |
Contributor
|
LGTM |
Contributor
Author
|
I need to wait until we have a green engine revision. |
- [x] Remove the two stage initial boot process. - [x] Remove the loader screen app. - [x] Don't report reload times for the initial reload because we are switching from a snapshot to source and that will always be worst case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
switching from a snapshot to source and that will always be worst case.
Fixes #6508