AdoptAWidget: FittedBox#69503
AdoptAWidget: FittedBox#69503fluttergithubbot merged 7 commits intoflutter:masterfrom singhsuryanshu:update-fitted-box-widget
Conversation
flutter-dashboard
bot
added
the
framework
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
| /// {@youtube 560 315 https://www.youtube.com/watch?v=T4Uehk3_wlY} | ||
| /// | ||
| /// | ||
| ///{@tool sample --template=stateless_widget_scaffold_center.tmpl} |
There was a problem hiding this comment.
You don't need the .tmpl suffix here. Also, Make sure there's at least one space between the code comment /// and the comment contents, here and throughout the change.
| ///{@tool sample --template=stateless_widget_scaffold_center.tmpl} | |
| /// {@tool sample --template=stateless_widget_scaffold_center} |
| /// | ||
| ///{@tool sample --template=stateless_widget_scaffold_center.tmpl} | ||
| /// | ||
| ///In this example, the image is stretched to fill the entire [Container](https://master-api.flutter.dev/flutter/widgets/Container-class.html) which would not happen normally without using FittedBox. |
There was a problem hiding this comment.
- Make sure that each line is shorter than 80 characters if possible
- The dartdocs automatically link widgets, so you do not need to include the URL like you would in a Github comment
| ///In this example, the image is stretched to fill the entire [Container](https://master-api.flutter.dev/flutter/widgets/Container-class.html) which would not happen normally without using FittedBox. | |
| /// In this example, the image is stretched to fill the entire [Container], which would | |
| /// not happen normally without using FittedBox. |
| ///```dart | ||
| ///Widget build(BuildContext) { | ||
| /// return Container( | ||
| /// height: 400, | ||
| /// width: 300, | ||
| /// color: Colors.red, | ||
| /// child: FittedBox( | ||
| /// child: Image.network('https://flutter.github.io/assets-for-api-docs/assets/widgets/owl-2.jpg'), | ||
| /// fit: BoxFit.fill, | ||
| /// ), | ||
| /// ); | ||
| ///} | ||
| ///``` |
There was a problem hiding this comment.
| ///```dart | |
| ///Widget build(BuildContext) { | |
| /// return Container( | |
| /// height: 400, | |
| /// width: 300, | |
| /// color: Colors.red, | |
| /// child: FittedBox( | |
| /// child: Image.network('https://flutter.github.io/assets-for-api-docs/assets/widgets/owl-2.jpg'), | |
| /// fit: BoxFit.fill, | |
| /// ), | |
| /// ); | |
| ///} | |
| ///``` | |
| /// ```dart | |
| /// Widget build(BuildContext) { | |
| /// return Container( | |
| /// height: 400, | |
| /// width: 300, | |
| /// color: Colors.red, | |
| /// child: FittedBox( | |
| /// child: Image.network('https://flutter.github.io/assets-for-api-docs/assets/widgets/owl-2.jpg'), | |
| /// fit: BoxFit.fill, | |
| /// ), | |
| /// ); | |
| /// } | |
| /// ``` |
| ///``` | ||
| /// | ||
| /// | ||
| ///{@end-tool} |
There was a problem hiding this comment.
| ///{@end-tool} | |
| /// {@end-tool} |
| ///} | ||
| ///``` | ||
| /// | ||
| /// |
There was a problem hiding this comment.
Remove extra line
| /// |
| /// | ||
| /// {@youtube 560 315 https://www.youtube.com/watch?v=T4Uehk3_wlY} | ||
| /// | ||
| /// |
There was a problem hiding this comment.
nit: Just caught this extra line as well
| /// |
shihaohong
added
d: api docs
|
The checks are not running ..... |
|
@singhsuryanshu The remaining checks are queued but not finished yet |
|
This pull request is not suitable for automatic merging in its current state.
|
|
@singhsuryanshu Thanks for participating in AdoptAWidget. We would like to send you a special thanks. If you are interested, please send an email to nyener at google dot com and provide a link to this issue. |
4 participants
AdoptAWidget: FittedBox
Added a code / DartPad sample to the FittedBox API Docs
This pull request is:
closes #69478