Skip to content

AdoptAWidget: Tooltip#69518

Merged
fluttergithubbot merged 4 commits intoflutter:masterfrom
tsvillain:update-tooltip
Nov 1, 2020
Merged

AdoptAWidget: Tooltip#69518
fluttergithubbot merged 4 commits intoflutter:masterfrom
tsvillain:update-tooltip

Conversation

@tsvillain
Copy link
Contributor

@tsvillain tsvillain commented Nov 1, 2020

DartPad Sample added in Tooltip API docs

This pull request is:

  • A code sample

closes #69489

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Nov 1, 2020
@flutter-dashboard
Copy link

flutter-dashboard bot commented Nov 1, 2020

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Nov 1, 2020
@tsvillain tsvillain requested a review from shihaohong November 1, 2020 09:13
shihaohong
shihaohong approved these changes Nov 1, 2020
View reviewed changes
Copy link
Contributor

@shihaohong shihaohong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a tiny grammar nitpick

shihaohong
shihaohong reviewed Nov 1, 2020
View reviewed changes
Copy link
Contributor

@shihaohong shihaohong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have some suggestions and some corrections

@tsvillain
Copy link
Contributor Author

tsvillain commented Nov 1, 2020

Have some suggestions and some corrections

Thank you for your correction and suggestions will update the PR accordingly.

@fluttergithubbot fluttergithubbot merged commit 5511abd into flutter:master Nov 1, 2020
@johnpryan
Copy link
Contributor

johnpryan commented Nov 11, 2020

@tsvillain Thanks for participating in AdoptAWidget. We would like to send you a special thanks. If you are interested, please send an email to nyener at google dot com and provide a link to this issue.

@tsvillain
Copy link
Contributor Author

tsvillain commented Nov 12, 2020

@johnpryan thank you for this.
I'll get in touch.
I will make more contributions to this framework 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@shihaohong shihaohong shihaohong approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Adopt a Widget - Tooltip

4 participants

@tsvillain @johnpryan @shihaohong @fluttergithubbot