[flutter_tools] remove unused or no longer useful code#69547
Merged
fluttergithubbot merged 2 commits intoflutter:masterfrom Nov 3, 2020
Merged
[flutter_tools] remove unused or no longer useful code#69547fluttergithubbot merged 2 commits intoflutter:masterfrom
fluttergithubbot merged 2 commits intoflutter:masterfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flutter-dashboard
bot
added
the
tool
shihaohong
approved these changes
Nov 2, 2020
Contributor
|
Not sure why, but all the LUCI bots are stalled in the |
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
godofredoc
added a commit
to flutter/cocoon
that referenced
this pull request
Nov 3, 2020
* Add retries to buildbucket tries. Sometimes the buildbucket requests are raising exceptions and github status stays on pending forever. Bug: flutter/flutter#69547 * Add a delayFactor.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
waitGroup is not used for checking nulls currently, so it provides no value over Future.wait.
isRunningFromDaemon is not used