Skip to content

Remove deprecated methods from BuildContext#69620

Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom
goderbauer:flutterfix
Jan 8, 2021
Merged

Remove deprecated methods from BuildContext#69620
fluttergithubbot merged 1 commit intoflutter:masterfrom
goderbauer:flutterfix

Conversation

@goderbauer
Copy link
Member

@goderbauer goderbauer commented Nov 2, 2020 •
edited
Loading

Description

This removes the deprecated BuildContext methods that has reached the EOL . See table below:

Before After
inheritFromElement dependOnInheritedElement
inheritFromWidgetOfExactType dependOnInheritedWidgetOfExactType
ancestorInheritedElementForWidgetOfExactType getElementForInheritedWidgetOfExactType
ancestorWidgetOfExactType findAncestorWidgetOfExactType
ancestorStateOfType findAncestorStateOfType
rootAncestorStateOfType findRootAncestorStateOfType
ancestorRenderObjectOfType findAncestorRenderObjectOfType

Similar methods exist on the Element class and will be removed from there in #72903.

Part of deprecations that are slated for removal for next release in https://flutter.dev/go/deprecation-lifetime

More context: https://medium.com/flutter/deprecation-lifetime-in-flutter-e4d76ee738ad

Related Issues

Deprecated in #44189

Tests

Tests for quick fix tool.

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.

@flutter-dashboard flutter-dashboard bot added framework flutter/packages/flutter repository. See also f: labels. work in progress; do not review labels Nov 2, 2020
@google-cla google-cla bot added the cla: yes label Nov 2, 2020
goderbauer
goderbauer commented Nov 2, 2020
View reviewed changes
packages/flutter/lib/fix_data.yaml Outdated
Copy link
Member Author

@goderbauer goderbauer Nov 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bwilkerson Where can we link to here?

Copy link
Contributor

@bwilkerson bwilkerson Nov 3, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't currently have a published version of the docs. They'll be the contents of the "User documentation" doc you've seen. I'd like to flesh them out a bit more before publishing them, but if we need them to be published sooner than that let me know.

Any additional feedback you have on the doc as a result of using it while writing this file would be much appreciated. (With thanks for your previous comment about adding some complete examples.)

goderbauer
goderbauer commented Nov 2, 2020
View reviewed changes
packages/flutter/lib/fix_data.yaml Outdated
Copy link
Member Author

@goderbauer goderbauer Nov 2, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see that coming up with the correct list here will be difficult. It will be easy to miss a lib that exports the symbol...

Copy link
Contributor

@bwilkerson bwilkerson Nov 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a valid concern.

The design tradeoff is that we have less information that we can use to ensure that we're selecting the correct change in the case where a declaration has been removed. Having the URIs doesn't absolutely guarantee that we won't do the wrong thing, but it does make it significantly less likely. Unfortunately, I don't have concrete numbers for how often we'd do the wrong thing (either with or without them), but I am concerned about the effect on user trust if the tool makes incorrect changes.

@goderbauer
Copy link
Member Author

goderbauer commented Nov 2, 2020

/cc @Piinks

@goderbauer
Copy link
Member Author

goderbauer commented Nov 2, 2020

We have to come up with a way to test these fixes. @bwilkerson Have you already given testing these definitions some thoughts?

devoncarew
devoncarew reviewed Nov 3, 2020
View reviewed changes
packages/flutter/lib/fix_data.yaml Outdated
Copy link
Contributor

@devoncarew devoncarew Nov 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a drive by comment, you may want liberal use of whitespace and # comments to help separate the individual refactors. This file will likely get pretty large and will be tough to navigate w/o some visual separation between fixes.

Copy link
Member Author

@goderbauer goderbauer Nov 3, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed and done.

bwilkerson
bwilkerson reviewed Nov 3, 2020
View reviewed changes
packages/flutter/lib/fix_data.yaml Outdated
Copy link
Contributor

@bwilkerson bwilkerson Nov 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless the distinction is important to users we ought to be consistent in the naming of these actions. Consider changing "Rename" to "Migrate".

@devoncarew devoncarew mentioned this pull request Nov 11, 2020
Closed
@goderbauer goderbauer closed this Nov 11, 2020
@goderbauer goderbauer deleted the flutterfix branch November 11, 2020 21:25
@goderbauer goderbauer restored the flutterfix branch November 11, 2020 21:26
@goderbauer goderbauer reopened this Nov 11, 2020
@Piinks
Copy link
Contributor

Piinks commented Dec 23, 2020

@goderbauer do you want to move forward with this change?

@Piinks
Copy link
Contributor

Piinks commented Dec 23, 2020

The tests that need to be added here are almost the same as #72903
This change will need to land before that one.

@Piinks Piinks mentioned this pull request Dec 23, 2020
Merged
9 tasks
@goderbauer
Copy link
Member Author

goderbauer commented Jan 5, 2021

@goderbauer do you want to move forward with this change?

Yes, I'll update this PR.

@goderbauer goderbauer changed the title Add fix_data.yaml with first 7 fixes Remove deprecated methods from BuildContext Jan 7, 2021
@flutter-dashboard flutter-dashboard bot added f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. labels Jan 7, 2021
@goderbauer goderbauer marked this pull request as ready for review January 7, 2021 22:22
@flutter-dashboard
Copy link

flutter-dashboard bot commented Jan 7, 2021

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@goderbauer goderbauer requested a review from Piinks January 7, 2021 22:22
Piinks
Piinks reviewed Jan 7, 2021
View reviewed changes
packages/flutter/lib/fix_data.yaml Outdated
Copy link
Contributor

@Piinks Piinks Jan 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooh I see, this is the date of the deprecation? (#44189 here?)

Piinks
Piinks approved these changes Jan 7, 2021
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flutter_LGTM
Thank you!

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Jan 7, 2021

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Piinks Piinks added the c: API break Backwards-incompatible API changes label Jan 8, 2021
@Piinks
Copy link
Contributor

Piinks commented Jan 8, 2021

Google tests have been fixed, this has a merge conflict now though. Strange Resolve conflicts is disabled here.

@goderbauer
Copy link
Member Author

goderbauer commented Jan 8, 2021

Merge conflict is resolved.

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Jan 8, 2021

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot merged commit 535392b into flutter:master Jan 8, 2021
@mohammadwali mohammadwali mentioned this pull request Jan 9, 2021
Closed
@sma sma mentioned this pull request Jan 11, 2021
Closed
@Piinks Piinks mentioned this pull request Jan 11, 2021
Merged
9 tasks
@goderbauer goderbauer deleted the flutterfix branch January 15, 2021 18:38
@Shvet Shvet mentioned this pull request Jan 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bwilkerson bwilkerson bwilkerson left review comments

@Piinks Piinks Piinks approved these changes

+1 more reviewer

@devoncarew devoncarew devoncarew left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: API break Backwards-incompatible API changes f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@goderbauer @Piinks @fluttergithubbot @devoncarew @bwilkerson @dnfield