Skip to content

Update CocoaPods recommended version to 1.9#69809

Merged
jmagman merged 2 commits intoflutter:masterfrom
jmagman:cocoapods-1-9
Nov 5, 2020
Merged

Update CocoaPods recommended version to 1.9#69809
jmagman merged 2 commits intoflutter:masterfrom
jmagman:cocoapods-1-9

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Nov 4, 2020 •
edited
Loading

Description

CocoaPods 1.9 introduced support for xcframeworks. It was released in February 2020.

Flutter will likely need to start being distributed as an xcframework to support Apple Silicon simulators. Nudge people to start upgrading.

Screen Shot 2020-11-04 at 12 51 54 PM

Related Issues

Fixes #69808
Fixes #69807

See #52071 for the last time this was done.

#60109
#64502

Tests

Updated cocoapods_test

@jmagman jmagman added platform-ios iOS applications specifically t: xcode "xcodebuild" on iOS and general Xcode project management labels Nov 4, 2020
@jmagman jmagman self-assigned this Nov 4, 2020
@flutter-dashboard flutter-dashboard bot added tool Affects the "flutter" command-line tool. See also t: labels. work in progress; do not review labels Nov 4, 2020
@google-cla google-cla bot added the cla: yes label Nov 4, 2020
@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Nov 4, 2020
@jmagman
Copy link
Member Author

jmagman commented Nov 4, 2020

This seems to have worked on the builder:

Fetching cocoapods 1.9.3
Installing cocoapods 1.9.3

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8864525671995568160/+/steps/Install_gems/0/steps/install_gems/0/stdout

@jmagman jmagman marked this pull request as ready for review November 5, 2020 02:01
@jmagman
Copy link
Member Author

jmagman commented Nov 5, 2020

This should probably wait for #69829 to make sure the devicelab machine have a new enough version of CocoaPods but I'm tempted to yolo merge this since it shouldn't actually cause any test failures, just add the doctor warning.

jonahwilliams
jonahwilliams approved these changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tool changes LGTM.

I think the devicelab will not fail if doctor checks don't all come back positive

christopherfujino
christopherfujino reviewed Nov 5, 2020
View reviewed changes
packages/flutter_tools/test/general.shard/macos/cocoapods_test.dart
testWithoutContext('detects above recommended version', () async {
pretendPodIsInstalled();
pretendPodVersionIs('1.8.1');
pretendPodVersionIs('1.9.1');
Copy link
Contributor

@christopherfujino christopherfujino Nov 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a blocker, but should we be warning if the .z is above the recommended version?

Copy link
Member Author

@jmagman jmagman Nov 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, what do you mean? This test shows it returning CocoaPodsStatus.recommended which doesn't translate to a warning.

Copy link
Contributor

@christopherfujino christopherfujino Nov 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh, sorry, you're right.

christopherfujino
christopherfujino approved these changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as keeper of the gemfile.lock file, i approve of this message.

@jmagman jmagman mentioned this pull request Nov 5, 2020
Closed
@jmagman
Copy link
Member Author

jmagman commented Nov 5, 2020

Google tests unrelated #69923

@jmagman jmagman merged commit bc2a4a6 into flutter:master Nov 5, 2020
@jmagman jmagman deleted the cocoapods-1-9 branch November 5, 2020 23:13
This was referenced Nov 19, 2020
Merged
Merged
@jmagman jmagman mentioned this pull request Dec 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. platform-ios iOS applications specifically t: xcode "xcodebuild" on iOS and general Xcode project management tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Upgrade CocoaPods gem version on builders Update CocoaPods recommended version to 1.9

3 participants

@jmagman @christopherfujino @jonahwilliams