Build either iphoneos or iphonesimulator App.framework, not both#69840
Merged
jmagman merged 1 commit intoflutter:masterfrom Nov 5, 2020
Merged
Build either iphoneos or iphonesimulator App.framework, not both#69840jmagman merged 1 commit intoflutter:masterfrom
jmagman merged 1 commit intoflutter:masterfrom
Conversation
jmagman
added
platform-ios
flutter-dashboard
bot
added
tool
9 tasks
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
Member
Author
|
Those Google test failures are definitely unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Next piece of #69334.
With the upcoming support for Apple Silicon ARM simulators, App.framework can no longer contain architectures for both
iphoneosandiphonesimulatorsince they need to be build against different SDKs, but they can no longer belipod together (lipocomplains both binaries contain arm64 and fails).iphoneosandiphonesimulatordirectories (Build App.framework directly to build directory #69699)iphoneosandiphonesimulatorSDK from Xcode instead of trying to guess from the architectures (to stop assuming x86 == simulator). Use it foraot(Compile snapshot_assembly with sdk root set in Xcode #69731).flutter build ios-frameworkto pull out the universal and xcframework methods to be reused in this PR (Methods in build_ios_framework for universal and XCFrameworks #69736)lipoing from debug stub framework step and only use the requestediphoneosoriphonesimulatorSDK, not for both. Refactorflutter build ios-frameworkas needed (this PR).Related Issues
Support #69334