Roll engine and fix pubspecs that do not have a Dart SDK constraint#70078
Merged
mit-mit merged 12 commits intoflutter:masterfrom Nov 9, 2020
Merged
Roll engine and fix pubspecs that do not have a Dart SDK constraint#70078mit-mit merged 12 commits intoflutter:masterfrom
mit-mit merged 12 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
engine
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flutter-dashboard
bot
added
the
tool
zanderso
changed the title
zanderso
approved these changes
Nov 9, 2020
|
|
||
| // This file uses Dart 2.12 semantics. This is needed as we can't upgrade | ||
| // the SDK constraint to `>=2.12.0-0` before the deps are ready. | ||
| // @dart=2.12 |
Member
|
Tool tests are failing due to a missing constraint here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Attempt to address the Dart breaking change that
pubspec.yamlfiles must have a Dart SDK constraint.Related Issues
Breaking change that causes this: dart-lang/sdk#44072
Previous fix for this: #70030
Failed roll after above fix: #70039