Skip to content

Revert "Allow any iOS app to be added to an existing host app"#70739

Merged
dnfield merged 1 commit intomasterfrom
revert-70647-build-ios-framework
Nov 18, 2020
Merged

Revert "Allow any iOS app to be added to an existing host app"#70739
dnfield merged 1 commit intomasterfrom
revert-70647-build-ios-framework

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Nov 18, 2020

Reverts #70647

See https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8863328391455486464/+/steps/run_test.dart_for_build_tests_shard_and_subshard_0/0/stdout#L23291_0

[   +3 ms] ════════════════════════════════════════════════════════════════════════════════
            Building a deployable iOS app requires a selected Development Team with a 
            Provisioning Profile. Please ensure that a Development Team is selected by:
              1- Open the Flutter project's Xcode target with
                   open ios/Runner.xcworkspace
              2- Select the 'Runner' project in the navigator then the 'Runner' target
                 in the project settings
              3- Make sure a 'Development Team' is selected. 
                 - For Xcode 10, look under General > Signing > Team.
                 - For Xcode 11 and newer, look under Signing & Capabilities > Team.
                 You may need to:
                     - Log in with your Apple ID in Xcode first
                     - Ensure you have a valid unique Bundle ID
                     - Register your device with your Apple Developer Account
                     - Let Xcode automatically provision a profile for your app
              4- Build or run your project again
            For more information, please visit:
              https://flutter.dev/setup/#deploy-to-ios-devices
            Or run on an iOS simulator without code signing
            ════════════════════════════════════════════════════════════════════════════════

@dnfield dnfield requested a review from jmagman November 18, 2020 05:19
@flutter-dashboard flutter-dashboard bot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Nov 18, 2020
@google-cla google-cla bot added the cla: yes label Nov 18, 2020
@dnfield
Copy link
Contributor Author

dnfield commented Nov 18, 2020

Going to land on red TBR @jmagman @xster to get the build green

@dnfield dnfield merged commit aab9a76 into master Nov 18, 2020
@dnfield dnfield deleted the revert-70647-build-ios-framework branch November 18, 2020 05:40
@jmagman
Copy link
Member

jmagman commented Nov 18, 2020

@dnfield that's a recently very common infra flake

unable to find sdk 'iphoneos13.6'

@dnfield
Copy link
Contributor Author

dnfield commented Nov 18, 2020

Ahhh so it tried to build for a device?

@dnfield
Copy link
Contributor Author

dnfield commented Nov 18, 2020

Ahh #68144. I'll reland...

dnfield added a commit that referenced this pull request Nov 18, 2020
@dnfield
Revert "Revert "Allow any iOS app to be added to an existing host app (…
24d0e35 
…#70647)" (#70739)"

This reverts commit aab9a76.
@dnfield dnfield mentioned this pull request Nov 18, 2020
Merged
@jmagman
Copy link
Member

jmagman commented Nov 18, 2020

Ahhh so it tried to build for a device?

No, the targeted sdk is missing on the builder.

@dnfield
Copy link
Contributor Author

dnfield commented Nov 18, 2020

Ahh ok, I was thinking that it somehow defaulted to trying to build for device, but I guess this is just a generic error message we show when xcodebuild fails because it's usually a culprit to look at (or otherwise at least to use Xcode to figure things out).

dnfield added a commit that referenced this pull request Nov 18, 2020
@dnfield
Revert "Revert "Allow any iOS app to be added to an existing host app (…
be2e7bb 
…#70647)" (#70739)" (#70740)

This reverts commit aab9a76.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagman jmagman Awaiting requested review from jmagman

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dnfield @jmagman