Make RenderFlex flex to fill min extent and remove intrinsics from SliverFillRemaining#70855
Closed
goderbauer wants to merge 2 commits intoflutter:masterfrom
Closed
Make RenderFlex flex to fill min extent and remove intrinsics from SliverFillRemaining#70855goderbauer wants to merge 2 commits intoflutter:masterfrom
goderbauer wants to merge 2 commits intoflutter:masterfrom
Conversation
…nderSliverFillRemaining
Piinks
reviewed
Nov 19, 2020
Contributor
Piinks
left a comment
There was a problem hiding this comment.
The RenderSliverFillRemainingAndOverscroll is still using intrinsics because it needs to know how much space the child would occupy if it doesn't reach into the overscroll. For that, we need to know the intrinsics of the child.
Can you add a comment to this class that adds more clarity to why we use intrinsics there? :)
Member
Author
Done. |
Contributor
|
LGTM. I'm curious if this breaks anything in google3. |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With a fix to RenderFlex we can remove intrinsics from one of the
SliverFillRemainings.Fix to RenderFlex: If a min extent is given, it should flex its children to at least fill the min extent even when the max extent is unbound. After all, it was asked to provide content for at least the min extent.
The
RenderSliverFillRemainingAndOverscrollis still using intrinsics because it needs to know how much space the child would occupy if it doesn't reach into the overscroll. For that, we need to know the intrinsics of the child.Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.