Wait for Android plugin to load before configuring plugin dependency#70970
Merged
blasten merged 2 commits intoflutter:masterfrom Nov 21, 2020
Merged
Wait for Android plugin to load before configuring plugin dependency#70970blasten merged 2 commits intoflutter:masterfrom
blasten merged 2 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
the
tool
Author
|
@xster test added |
blasten
force-pushed
the
after_evaluate
branch
from
c0805ce to
6b440f2
Compare
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
Contributor
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
This should not be running in the devicelab since it does not require dedicated hardware.
Author
|
I discussed adding this to LUCI with @godofredoc. Currently, it's a manual process, and cannot be done in a single PR like this one. This would have to be done after the holidays most likely. |
Contributor
|
I filled #70978 to track. Its not so urgent that we need to deal with it right now |
Author
|
Thanks @jonahwilliams ! I know @godofredoc is on top of improving this devX. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implementationis provided by the Android Gradle plugin. It cannot be called before the Android plugin has loaded, and registered animplementationcallback.afterEvaluateensures thatimplementationis only called after this plugin loaded.