Create abstraction layer for dart:io's Process commands#7100
Merged
tvolkert merged 4 commits intoflutter:masterfrom Nov 30, 2016
tvolkert:os-abstraction-layer
Merged
Create abstraction layer for dart:io's Process commands#7100tvolkert merged 4 commits intoflutter:masterfrom tvolkert:os-abstraction-layer
tvolkert merged 4 commits intoflutter:masterfrom
tvolkert:os-abstraction-layer
Conversation
With this change, they're run via instance methods on an object obtained through the context. This will allow us to substitute that object in tests with replay/record versions to allow us to mock out the os-layer in tests.
Contributor
Author
| context.putIfAbsent(IOSSimulatorUtils, () => new IOSSimulatorUtils()); | ||
| context.putIfAbsent(SimControl, () => new SimControl()); | ||
| context.putIfAbsent(Usage, () => new Usage()); | ||
| context.putIfAbsent(ProcessManager, () => new ProcessManager()); |
Contributor
There was a problem hiding this comment.
You need to add the same putIfAbsent into test/src/context.dart
Contributor
|
LGTM after figuring out travis failures |
Contributor
danrubel
approved these changes
Nov 30, 2016
Contributor
danrubel
left a comment
danrubel
left a comment
There was a problem hiding this comment.
LGTM with suggestion for you to address as you see fit.
| ); | ||
| } | ||
|
|
||
| ProcessResult runSync( |
Contributor
There was a problem hiding this comment.
I would prefer if we only used the run method throughout flutter tools and deleted this runSync method.
Contributor
Author
There was a problem hiding this comment.
I like it, but it'd be a pretty invasive change, so let's do it in a different change.
Contributor
Author
|
I had to change around how context overrides are applied in the tests in order to fix the Travis failures. PTAL. |
Contributor
|
I like the new test overrides interface. LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change, they're run via instance methods on an object
obtained through the context. This will allow us to substitute
that object in tests with replay/record versions to allow us to
mock out the os-layer in tests.