[BottomNavigationBar] Adds more control to ToolTip#71079
Merged
fluttergithubbot merged 13 commits intoflutter:masterfrom Dec 16, 2020
Merged
[BottomNavigationBar] Adds more control to ToolTip#71079fluttergithubbot merged 13 commits intoflutter:masterfrom
fluttergithubbot merged 13 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
f: material design
yash1200
changed the title
Contributor
|
Setting |
Contributor
|
cc @HansMuller |
packages/flutter/lib/src/widgets/bottom_navigation_bar_item.dart
Outdated
Show resolved
Hide resolved
packages/flutter/lib/src/widgets/bottom_navigation_bar_item.dart
Outdated
Show resolved
Hide resolved
packages/flutter/lib/src/widgets/bottom_navigation_bar_item.dart
Outdated
Show resolved
Hide resolved
LongCatIsLooong
approved these changes
Dec 13, 2020
Contributor
LongCatIsLooong
left a comment
LongCatIsLooong
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the comprehensive test cases.
Contributor
Author
|
@LongCatIsLooong I think this should be merged now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
showToolTipproperty inBottomNavigationBarandtoolTipproperty inBottomNavigationBarItem.Related Issues
Fixes #71049
Tests
I added the following tests:
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read [Handling breaking changes].