Move Flutter.podspec to add-to-app project template#71103
Merged
jmagman merged 5 commits intoflutter:masterfrom Nov 24, 2020
Merged
Move Flutter.podspec to add-to-app project template#71103jmagman merged 5 commits intoflutter:masterfrom
jmagman merged 5 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
the
tool
jmagman
added
a: existing-apps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Flutter.podspecis only used in add-to-app modules. Stop using the one shipped in the engine artifacts and instead generate from the tool template.This doesn't need a migration--previous versions of Flutter have already copied an identical
Flutter.podspecto that spot, andflutter cleantotally recreates.iosanyway.Related Issues
#60109 will require Flutter.podspec to change to
s.vendored_frameworks = 'Flutter.xcframework'. It will be easier to handle this migration in the tool instead of coordinating a framework repo change with the right engine roll.Tests
Added file to
create_test. This logic is also tested inmodule_test_iosandbuild_ios_framework_module_test.