Merged
Conversation
flutter-dashboard
bot
added
the
tool
jmagman
force-pushed
the
artifact-xcf
branch
from
b2c377b to
3b4ac16
Compare
Member
Author
|
Google test failing because #71095 hasn't been rolled yet. |
jmagman
force-pushed
the
artifact-xcf
branch
from
3b4ac16 to
408f455
Compare
Member
Author
|
Recipe changed merged at https://flutter.googlesource.com/recipes/+/d3f2a7ef840805c27163a0b274f15a05cc3401e4 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add unused
Artifact.flutterXcframeworkto get ready for the XCFramework being added to the uploaded engine artifacts.Pass
EnvironmentTypeinto the artifacts logic. This will be used to differentiateFlutter.xcframework/ios-x86_64-simulator/Flutter.frameworkfromFlutter.xcframework/ios-arm64_armv7/Flutter.framework. Parse the environment (iOS vs iOS simulator) in the ios build system target.Related Issues
Will be used as part of #60109 when the xcframework is added to artifacts.
Tests
artifacts test, ios build system target test