Skip to content

[gen-l10n] Fix forwarding of output-dir in l10n.yaml file#71128

Merged
fluttergithubbot merged 2 commits intoflutter:masterfrom
shihaohong:fix-l10n-yaml
Dec 4, 2020
Merged

[gen-l10n] Fix forwarding of output-dir in l10n.yaml file#71128
fluttergithubbot merged 2 commits intoflutter:masterfrom
shihaohong:fix-l10n-yaml

Conversation

@shihaohong
Copy link
Contributor

@shihaohong shihaohong commented Nov 24, 2020

Description

Forwards --output-dir to the l10n.yaml way of setting up gen-l10n.

Related Issues

Fixes #71127.

Tests

I added the following tests:

  • Modify existing test to take extra option into account.

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 24, 2020
@google-cla google-cla bot added the cla: yes label Nov 24, 2020
@shihaohong shihaohong changed the title Fix forwarding of output-dir in l10n.yaml file [gen-l10n] Fix forwarding of output-dir in l10n.yaml file Nov 24, 2020
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 95e444c into flutter:master Dec 4, 2020
@shihaohong shihaohong deleted the fix-l10n-yaml branch January 6, 2021 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[gen-l10n] output-dir not forwarded in l10n.yaml

3 participants