Allow flavors and build types when using plugins#71738
Merged
fluttergithubbot merged 5 commits intoflutter:masterfrom Dec 7, 2020
Merged
Allow flavors and build types when using plugins#71738fluttergithubbot merged 5 commits intoflutter:masterfrom
fluttergithubbot merged 5 commits intoflutter:masterfrom
Conversation
dnfield
approved these changes
Dec 4, 2020
Contributor
dnfield
left a comment
There was a problem hiding this comment.
LGTM! thanks for the quick fix
thecalamiity
reviewed
Dec 4, 2020
added 2 commits
December 4, 2020 19:56
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, a project doesn't build if it includes a plugin and also defines a flavor or custom build type.
Related Issues
Fixes #71694
Tests
I added the following tests: e2e
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.