Constrain width/hight when asking child for intrinsics#71880
Merged
goderbauer merged 2 commits intoflutter:masterfrom Dec 9, 2020
Merged
Constrain width/hight when asking child for intrinsics#71880goderbauer merged 2 commits intoflutter:masterfrom
goderbauer merged 2 commits intoflutter:masterfrom
Conversation
13 tasks
goderbauer
added a commit
that referenced
this pull request
Dec 10, 2020
This reverts commit ceca634.
goderbauer
added a commit
that referenced
this pull request
Dec 11, 2020
goderbauer
added a commit
to goderbauer/flutter
that referenced
this pull request
Apr 15, 2021
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prior to this change the RenderConstrainedBox would not enforce the _additionalConstraints before asking its child for its intrinsics.
Related Issues
Fixes #27293.
Tests
I added the following tests:
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.