Ensure apps can build while using AGP 3.3.0#71964
Merged
fluttergithubbot merged 5 commits intoflutter:masterfrom Dec 9, 2020
Merged
Ensure apps can build while using AGP 3.3.0#71964fluttergithubbot merged 5 commits intoflutter:masterfrom
fluttergithubbot merged 5 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
c: contributor-productivity
dnfield
reviewed
Dec 9, 2020
Contributor
dnfield
left a comment
dnfield
left a comment
There was a problem hiding this comment.
Just style nits, overall should be fine
| final String gradlew = Platform.isWindows ? 'gradlew.bat' : 'gradlew'; | ||
| final String gradlewExecutable = Platform.isWindows ? '.\\$gradlew' : './$gradlew'; | ||
| final String gradlewExecutable = | ||
| Platform.isWindows ? '.\\$gradlew' : './$gradlew'; |
Contributor
There was a problem hiding this comment.
and elsewhere - it looks like dartfmt may have been applied where it shouldn't be.
| options: <String>[ | ||
| '--template=plugin', | ||
| '--platforms=android', | ||
| 'plugin_test' |
Contributor
There was a problem hiding this comment.
If you want to break it this way add a trailing comma
12 tasks
amirh
approved these changes
Dec 9, 2020
| pluginProject.dependencies.add( | ||
| "${buildType.name}CompileOnly", | ||
| "io.flutter:flutter_embedding_$flutterBuildMode:$engineVersion") | ||
| addApiDependencies( |
Contributor
There was a problem hiding this comment.
nit: does the Closure name addEmbeddingCompileOnlyDependency still makes sense?
Author
There was a problem hiding this comment.
Good catch. I renamed it, but after looking at some test cases, it would need to use api or compileOnly depending on the Gradle version.
christopherfujino
pushed a commit
to chris-forks/flutter
that referenced
this pull request
Dec 21, 2020
christopherfujino
added a commit
that referenced
this pull request
Jan 5, 2021
Co-authored-by: Emmanuel Garcia <[email protected]>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The embedding must be an API dependency in AGP 3.3.0. The most recent version allows this to be a compileOnly dependency, which is accurate as the embedding jar is provided by the app.
Tests
I added the following tests: integration test
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.