Skip to content

Revert "Migrate devicelab to package:vm_service"#72092

Merged
goderbauer merged 1 commit intomasterfrom
revert-71882-vm_svc_mig
Dec 10, 2020
Merged

Revert "Migrate devicelab to package:vm_service"#72092
goderbauer merged 1 commit intomasterfrom
revert-71882-vm_svc_mig

Conversation

@goderbauer
Copy link
Member

Reverts #71882

It is breaking some tests in devicelab:

Task failed with the following reason:
Timeout waiting for connection: Failed to connect to the task runner process

@flutter-dashboard flutter-dashboard bot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Dec 10, 2020
@google-cla google-cla bot added the cla: yes label Dec 10, 2020
@goderbauer goderbauer requested a review from dnfield December 10, 2020 20:55
@goderbauer
Copy link
Member Author

/tbr @dnfield

Merging on red to fix tree.
Merging without waiting for tests since it reverts the last commit.

@goderbauer goderbauer merged commit 78cbfbf into master Dec 10, 2020
@goderbauer goderbauer deleted the revert-71882-vm_svc_mig branch December 10, 2020 20:56
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants