Deal with infinity in intrinsics of RenderConstrainedBox#72095
Closed
goderbauer wants to merge 1 commit intoflutter:masterfrom
Closed
Deal with infinity in intrinsics of RenderConstrainedBox#72095goderbauer wants to merge 1 commit intoflutter:masterfrom
goderbauer wants to merge 1 commit intoflutter:masterfrom
Conversation
a5f7c7e to
be83975
Compare
be83975 to
c7323a1
Compare
Member
Author
|
CLosing for now since the change this is based on got reverted. |
goderbauer
added a commit
to goderbauer/flutter
that referenced
this pull request
Apr 15, 2021
8 tasks
9 tasks
lohnn
added a commit
to lohnn/flutter
that referenced
this pull request
Mar 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #71880. I missed the case where _additionalConstraints specify a min width/height of infinity (meaning that the box should be as big as the parent allows).
Related Issues
#27293
b/175263631
Tests
I added the following tests:
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.