Reland Move embedding and linking macOS Flutter frameworks into the tool#72372
Merged
jmagman merged 1 commit intoflutter:masterfrom Dec 15, 2020
Merged
Reland Move embedding and linking macOS Flutter frameworks into the tool#72372jmagman merged 1 commit intoflutter:masterfrom
jmagman merged 1 commit intoflutter:masterfrom
Conversation
Member
Author
|
I'm taking the liberty of assuming @stuartmorgan's LGTM from #71764. This change is identical, I've just rebased on the engine roll containing flutter/engine#22979. |
This was referenced Dec 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identical to #71764 except now it's on top of the engine change flutter/engine#22979
Description
macOS version of #51453. See details and discussion there.
Push linker and embedding logic into the tool so future changes (like distributing as an XCFramework, renaming FlutterMacOS.framework, etc) do not require changes in the user's project.
At some point FlutterMacOS.framework will ship with x86 and ARM slices. With this change, we will be able to introduce thinning (as iOS does) in the script without requiring a user project migration.
This change would also set us up to stop copying
FlutterMacOS.frameworktoFlutter/ephemeral. On iOS, for example, the framework is copied directly from the artifacts directory to theBUILT_PRODUCTS_DIRso there's never a mismatch between a Release build and a Debug version of Flutter.Changes
disable_input_output_pathsfrom the generated Podfile, and from the example projects. Now that FlutterMacOS.framework isn't being technically emitted by a build phase, the Disable CocoaPods input and output paths in Xcode build phase and adopt new Xcode build system #33684 workaround is no longer necessary.Future Documentation
disable_input_output_pathscan be deleted. We decided not to automatically migrate this for existing iOS projects.Related Issues
Fixes #56581
Part of #70413
Will make #60113 easier.
Tests
macos_project_migration_test