Exclude arm64 from supported iOS simulator architectures#73458
Merged
jmagman merged 1 commit intoflutter:masterfrom Jan 7, 2021
Merged
Exclude arm64 from supported iOS simulator architectures#73458jmagman merged 1 commit intoflutter:masterfrom
jmagman merged 1 commit intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
c: contributor-productivity
jmagman
added
platform-ios
jmagman
changed the title
jmagman
commented
Jan 7, 2021
| buildCommands.addAll(<String>['-sdk', 'iphoneos']); | ||
| } else { | ||
| buildCommands.addAll(<String>['-sdk', 'iphonesimulator', '-arch', 'x86_64']); | ||
| buildCommands.addAll(<String>['-sdk', 'iphonesimulator']); |
Member
Author
There was a problem hiding this comment.
\cc @gw280 FYI when you test your ARM framework you'll need to either comment out the two places I added EXCLUDED_ARCHS[sdk=iphonesimulator*]=arm64 i386 or you can override the build settings in your test project. Let me know if you need assistance.
jmagman
added a commit
that referenced
this pull request
Jan 7, 2021
This was referenced Jan 12, 2021
This was referenced Feb 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exclude unsupported new arm64 and old i386 iOS simulators at the build setting layer instead of passing
-sdk x86_64as an option toxcodebuild. This will allow the excluded architectures to be excluded when the project is run from Xcode, instead of just from thefluttercommand line.Do this for plugin targets (in the podhelper) as well as in the Runner app target (Generated.xcconfig).
#64502 (comment)
Added a ios_content_validation_test case to target the simulator with
ONLY_ACTIVE_ARCH=NOwhich will target all valid architectures that have not been explicitly excluded. This test case would fail if arm64 or i386 were not excluded.