Skip to content

Re-enable a ensureVisible test case#73545

Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom
xu-baolin:0108ensure
Jan 13, 2021
Merged

Re-enable a ensureVisible test case#73545
fluttergithubbot merged 1 commit intoflutter:masterfrom
xu-baolin:0108ensure

Conversation

@xu-baolin
Copy link
Member

This test was close by #7920 and tracking by #7919.
But I can not found more details about the failures and I couldn't reproduce it after several years.

Now it can be passed on the latest master channel, so I want to open it, and if it fails in the future, I will follow up and solve it.

Fixes #7919

@xu-baolin xu-baolin requested a review from Piinks January 8, 2021 08:20
@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Jan 8, 2021
@google-cla google-cla bot added the cla: yes label Jan 8, 2021
@xu-baolin xu-baolin added the a: tests "flutter test", flutter_test, or one of our tests label Jan 8, 2021
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xu-baolin
Copy link
Member Author

LGTM

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make sure Scrollable.ensureVisible works with children before the center

3 participants