Move ios_content_validation_test to pre-submit tools test#73577
Merged
jmagman merged 9 commits intoflutter:masterfrom Jan 11, 2021
Merged
Move ios_content_validation_test to pre-submit tools test#73577jmagman merged 9 commits intoflutter:masterfrom
jmagman merged 9 commits intoflutter:masterfrom
Conversation
jmagman
added
the
c: contributor-productivity
flutter-dashboard
bot
added
the
tool
jmagman
force-pushed
the
ios-content
branch
2 times, most recently
from
04f968a to
4429c35
Compare
jmagman
commented
Jan 8, 2021
Member
Author
There was a problem hiding this comment.
This check wasn't even in the devicelab test. Bonus!
jmagman
commented
Jan 8, 2021
Member
Author
There was a problem hiding this comment.
Hm, this group skip didn't seem to work, it ran on Windows and Linux.
Member
Author
There was a problem hiding this comment.
Oh I know why, it was overridden at the test level dart-lang/test#545
thecalamiity
reviewed
Jan 8, 2021
packages/flutter_tools/test/integration.shard/ios_content_validation_test.dart
Outdated
Show resolved
Hide resolved
Member
Author
|
I can't test this, blocked by #73606 |
This reverts commit 2d14a6a.
This was referenced Jan 23, 2024
auto-submit bot
pushed a commit
that referenced
this pull request
Jan 26, 2024
…#142272) The archiving was running in devicelab because certs are needed to codesign (see #73577). However now the certs are available in chromium bots. Move the archiving test into the existing tool integration test, and delete the devicelab variant. arm64: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8757886514651624673/+/u/run_test.dart_for_tool_host_cross_arch_tests_shard_and_subshard_None/test_stdout#L6074_4 x64: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8757886514651624689/+/u/run_test.dart_for_tool_host_cross_arch_tests_shard_and_subshard_None/test_stdout#L6389_2 Part of #142070
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of the devicelab task ios_content_validation_test can be moved into the flutter_tool test integration shard. The archive part of the test needs to stay in the devicelab since it requires codesigning, and the provisioning profiles aren't set up in LUCI.
I reverted two of my own commits this week for post-submit failures in this test that could have been caught in pre-submit.