Skip to content

Enable bitcode for new iOS projects#73607

Closed
jmagman wants to merge 1 commit intoflutter:masterfrom
jmagman:archive-bitcode
Closed

Enable bitcode for new iOS projects#73607
jmagman wants to merge 1 commit intoflutter:masterfrom
jmagman:archive-bitcode

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Jan 8, 2021

Enable bitcode by default for new iOS projects.

Don't automatically migrate existing projects since it's possible to have dependencies that do not support bitcode, which would require users to turn off bitcode at the app level.

Fixes #39356
Possible as of #70224 which prevents mismatches archiving in release while linking against a debug Flutter.framework which only has the bitcode marker (see #39356 (comment) for details)

@jmagman jmagman self-assigned this Jan 8, 2021
@flutter-dashboard flutter-dashboard bot added d: examples Sample code and demos c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Jan 8, 2021
@google-cla google-cla bot added the cla: yes label Jan 8, 2021
@jmagman jmagman marked this pull request as ready for review January 9, 2021 00:45
@jmagman jmagman added platform-ios iOS applications specifically t: xcode "xcodebuild" on iOS and general Xcode project management labels Jan 9, 2021
@jmagman jmagman requested review from dnfield and xster January 9, 2021 03:20
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman
Copy link
Member Author

jmagman commented Jan 14, 2021

I have to think more about if this is a good idea since we don't have any archive validation tests, and that's where it would manifest. The solution would be to add documentation for what to do if a dependency doesn't support bitcode.

@jmagman
Copy link
Member Author

jmagman commented Jan 15, 2021

I'm going to close this for now until we have a more compelling reason to turn this on since it will only cause annoyance for people with dependencies that don't support bitcode, it "worked" before but now they are getting validation errors.
Maybe at some point Apple will require bitcode, in which case we can revisit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos platform-ios iOS applications specifically t: xcode "xcodebuild" on iOS and general Xcode project management tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bitcode on iOS should be enabled by default in our templates

2 participants