Skip to content

Remove deprecated BinaryMessages#73750

Merged
fluttergithubbot merged 4 commits intoflutter:masterfrom
Piinks:binaryMessages
Jan 28, 2021
Merged

Remove deprecated BinaryMessages#73750
fluttergithubbot merged 4 commits intoflutter:masterfrom
Piinks:binaryMessages

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Jan 11, 2021 •
edited
Loading

Description

This removes the deprecated BinaryMessages class and defaultBinaryMessenger getter that has reached the EOL .
Here is a table to reference the migrations for each:

Before After
BinaryMessenger get defaultBinaryMessenger Use ServicesBinding.instance.defaultBinaryMessenger
BinaryMessages Use BinaryMessenger
static BinaryMessages.handlePlatformMessage Use defaultBinaryMessenger.handlePlatformMessage
static BinaryMessages.send Use defaultBinaryMessenger.send
static BinaryMessages.setMessageHandler Use defaultBinaryMessenger.setMessageHandler
static BinaryMessages.setMockMessageHandler Use defaultBinaryMessenger.setMockMessageHandler

Part of deprecations that are slated for removal for next release in https://flutter.dev/go/deprecation-lifetime

More context: https://medium.com/flutter/deprecation-lifetime-in-flutter-e4d76ee738ad

Related Issues

Deprecated in #38464
#73910

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Jan 11, 2021
@flutter-dashboard
Copy link

flutter-dashboard bot commented Jan 11, 2021

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Jan 11, 2021
@Piinks Piinks added the c: API break Backwards-incompatible API changes label Jan 11, 2021
@Piinks Piinks mentioned this pull request Jan 12, 2021
Merged
11 tasks
@Piinks
Copy link
Contributor Author

Piinks commented Jan 12, 2021

Depends on flutter/plugins#3409

goderbauer
goderbauer reviewed Jan 13, 2021
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have quick fixes for moving from defaultBinaryMessenger to ServicesBinding.instance!.defaultBinaryMessenger.

@Piinks
Copy link
Contributor Author

Piinks commented Jan 21, 2021

Currently migrating internal customers.

@goderbauer goderbauer mentioned this pull request Jan 27, 2021
Closed
@Piinks
Copy link
Contributor Author

Piinks commented Jan 28, 2021

Customers are migrated. This is good to land. :)

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Jan 28, 2021

This pull request is not suitable for automatic merging in its current state.

  • Please get at least one approved review before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@Piinks Piinks requested a review from goderbauer January 28, 2021 00:58
goderbauer
goderbauer approved these changes Jan 28, 2021
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 164671e into flutter:master Jan 28, 2021
@pschuegr pschuegr mentioned this pull request Feb 2, 2021
Closed
@stuartmorgan-g stuartmorgan-g mentioned this pull request Mar 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

c: API break Backwards-incompatible API changes framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Piinks @fluttergithubbot @goderbauer