Exclude arm64 from valid iOS simulators#73755
Merged
jmagman merged 2 commits intoflutter:masterfrom Jan 12, 2021
Merged
Conversation
flutter-dashboard
bot
added
the
tool
Member
Author
|
@xster You were right, |
jmagman
force-pushed
the
exclude-archs
branch
from
fd5e411 to
f135ef6
Compare
flutter-dashboard
bot
added
the
c: contributor-productivity
jmagman
commented
Jan 12, 2021
| DEBUG_INFORMATION_FORMAT = dwarf; | ||
| ENABLE_STRICT_OBJC_MSGSEND = YES; | ||
| ENABLE_TESTABILITY = YES; | ||
| "EXCLUDED_ARCHS[sdk=iphonesimulator*]" = arm64; |
Member
Author
There was a problem hiding this comment.
Host apps need to add this to work on arm64 macOS. That's not new to this PR, but this PR actually makes it fail on a non-Apple Silicon device, like our test agents.
Edit: that's not true, it won't fail on x86 Macs on this PR. I forgot I had to change a bunch of settings to force it to fail to test that this worked locally. You can disregard this comment, this PR doesn't impact host x86 host apps.
jmagman
added a commit
that referenced
this pull request
Jan 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subset of #73458. It's similar but don't remove the
xcodebuild -sdk x86_64flag.Description
Exclude unsupported new arm64 and old i386 iOS simulators at the build setting layer. This will allow the excluded architectures to be excluded when the project is run from Xcode, instead of just from the
fluttercommand line.Do this for plugin targets (in the podhelper) as well as in the Runner app target (Generated.xcconfig).
Update the add-to-app host apps to exclude arm64 simulators since Flutter still doesn't contain that slice.
Sample code update: flutter/samples#646
Website docs update: flutter/website#5174
#64502 (comment)