Skip to content

Revert integration_test in flutter create template#74068

Merged
dnfield merged 2 commits intoflutter:masterfrom
dnfield:revert_templ
Jan 15, 2021
Merged

Revert integration_test in flutter create template#74068
dnfield merged 2 commits intoflutter:masterfrom
dnfield:revert_templ

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Jan 15, 2021 •
edited
Loading

Reverts #70240

This isn't ready for NNBD. Revert until it is.

Previously attempted in #74064

@jmagman fyi

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jan 15, 2021
@google-cla google-cla bot added the cla: yes label Jan 15, 2021
@dnfield dnfield requested a review from jonahwilliams January 15, 2021 19:41
jonahwilliams
jonahwilliams approved these changes Jan 15, 2021
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnfield dnfield changed the title Revert templ Revert integration_test in flutter create template Jan 15, 2021
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Jan 15, 2021

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Windows tool_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@dnfield
Copy link
Contributor Author

dnfield commented Jan 15, 2021

Google failure is a flake.

Windows failure is a flake - filing an issue to track that. See https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8858008542344509392/+/steps/run_test.dart_for_tool_tests_shard_and_subshard_integration/0/stdout#L6706_0

@dnfield dnfield merged commit 6a32859 into flutter:master Jan 15, 2021
@dnfield dnfield deleted the revert_templ branch January 15, 2021 21:13
@jmagman
Copy link
Member

jmagman commented Jan 15, 2021

Does this need a migration for people who already have this in their pubpsec from the template?

@dnfield
Copy link
Contributor Author

dnfield commented Jan 15, 2021

That is a good question. I think the critical thing is that the template not make it to our next stable. I don't think we need to migrate though. @jonahwilliams WDYT?

@jonahwilliams
Copy link
Contributor

jonahwilliams commented Jan 15, 2021

I don't think we need to migrate people off of it - there are probably users that have started to use integration test and we can't/shouldn't stop them.

@goderbauer goderbauer mentioned this pull request Jan 16, 2021
Merged
@jmagman jmagman mentioned this pull request Jan 20, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dnfield @fluttergithubbot @jmagman @jonahwilliams