Fix bugs with ext.flutter.activeDevToolsServerAddress#74423
Merged
christopherfujino merged 3 commits intoflutter:masterfrom Jan 21, 2021
Merged
Fix bugs with ext.flutter.activeDevToolsServerAddress#74423christopherfujino merged 3 commits intoflutter:masterfrom
christopherfujino merged 3 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
the
tool
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Contributor
|
Fixes #74431 |
Contributor
|
@kenzieschmoll is it safe for me to land this now? This is one of the pre-requisites for making |
Member
Author
|
Yes safe to land. |
Contributor
|
Thanks @kenzieschmoll. Landed on red |
Hixie
reviewed
Jan 21, 2021
| if (!silent) { | ||
| globals.printStatus('Restarted application in ${getElapsedAsMilliseconds(timer.elapsed)}.'); | ||
| } | ||
| unawaited(maybeCallDevToolsUriServiceExtension()); |
Contributor
There was a problem hiding this comment.
It would be good to have a comment saying why it's ok to ignore errors from this future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #74407
A completer was attempting to fire again after hot restarting - this PR fixes that. We also were not properly restoring the state of
ext.flutter.activeDevToolsServerAddresson hot restart, so this PR fixes that issue as well.Working on adding tests to verify fix.