Don't leak exceptions thrown by message channels#74446
Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom Jan 27, 2021
Merged
Don't leak exceptions thrown by message channels#74446fluttergithubbot merged 1 commit intoflutter:masterfrom
fluttergithubbot merged 1 commit intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
a: tests
Hixie
force-pushed
the
futures-in-test
branch
from
24c1b81 to
2cb248f
Compare
The test framework previously made it impossible to actually catch all exceptions from the message channels system, because it "forked" the future chain and didn't catch exceptions on its end of the fork. This flattens the future chain.
Hixie
force-pushed
the
futures-in-test
branch
from
2cb248f to
3666ee8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test framework previously made it impossible to actually catch all exceptions from the message channels system, because it "forked" the future chain and didn't catch exceptions on its end of the fork. This catches the exceptions on the forked branch. Originally I tried flattening the chain but that causes Zone issues in some tests with FakeAsync.
This unblocks flutter/packages#265 which, somehow, I don't even remember how, is part of the yak shave to fixing #64830.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.