Remove nullOk from Actions.invoke, add Actions.maybeInvoke#74680
Merged
gspencergoog merged 1 commit intoflutter:masterfrom Jan 26, 2021
Merged
Remove nullOk from Actions.invoke, add Actions.maybeInvoke#74680gspencergoog merged 1 commit intoflutter:masterfrom
gspencergoog merged 1 commit intoflutter:masterfrom
Conversation
2eb586a to
f4cff47
Compare
f4cff47 to
dcc1004
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This removes the
nullOkparameter fromActions.invoke, and adds anActions.maybeInvokefunction. The difference is that invoke will now always (in debug mode) throw if an enabled action isn't found, andmaybeInvokewill return null if an enabled action isn't found. Theinvokefunction can still return null as the result of the invocation, though, so I purposely didn't change the return value toObjectfromObject?.Related Issues
Tests
maybeInvoke, updatedinvoketests.Breaking Change