Show an X when images can't load.#74972
Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom Feb 3, 2021
Merged
Conversation
flutter-dashboard
bot
added
the
framework
|
Gold has detected about 3 untriaged digest(s) on patchset 1. |
|
Gold has detected about 2 untriaged digest(s) on patchset 1. |
Contributor
Author
|
cc @goderbauer |
goderbauer
approved these changes
Feb 2, 2021
Member
There was a problem hiding this comment.
Turn this into a {@tool snippet} so it gets analyzed?
Contributor
Author
There was a problem hiding this comment.
had to revert this, the snippet analysis logic doesn't like bare asserts.
Contributor
Author
|
Thanks for the review, will land on green. |
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
Hixie
force-pushed
the
image_error
branch
2 times, most recently
from
2261bd8 to
2c6cdff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an image can't be shown, in debug mode, this shows a red X with an error message. Should make it a bit easier to debug missing images.
Fixes #125.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.